Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use panic = 'abort' in dev profile #330

Closed
wants to merge 1 commit into from

Conversation

daira
Copy link
Contributor

@daira daira commented Jan 20, 2021

refs #78

Signed-off-by: Daira Hopwood [email protected]

@daira daira requested a review from str4d January 20, 2021 12:58
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #330 (86e4ec1) into master (47348af) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   64.79%   64.81%   +0.01%     
==========================================
  Files          69       69              
  Lines        7071     7071              
==========================================
+ Hits         4582     4583       +1     
+ Misses       2489     2488       -1     
Impacted Files Coverage Δ
zcash_history/src/tree.rs 57.83% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47348af...86e4ec1. Read the comment docs.

@daira
Copy link
Contributor Author

daira commented Jan 20, 2021

The clippy errors are unrelated to this PR.

@daira
Copy link
Contributor Author

daira commented Jan 21, 2021

This PR is not actually helpful, because the FFI I was trying to fix this potential problem for doesn't live in this workspace.

@daira daira closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant