FeaturePanel: New icon for the direction tag #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I will later change it back to an arrow for single directions |
zbycz
previously approved these changes
Oct 2, 2024
| }} | ||
| > | ||
| <AnimatedArrow start={start} end={end ?? start} /> | ||
| <DirectionIndicator start={start} end={end} /> |
There was a problem hiding this comment.
Could you perhaps make the line the same height as the other? Maybe make the indicator little smaller, and possibly with negative margins to overflow a little? (edit not sure how it will look :) )
Maybe centering the "Directions" label would be ok for start.
|
Great! One idea - what about adding a degrees sign after the numeric values? I think eg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change to a icon with some rays around a circle in the middle for the direction tag rendering.
Examples