Overloading OpenConnection function #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Connection with Credential to connect using user and password
| @@ -124,6 +126,18 @@ | |||
| DatabaseConnection[host, port, JavaNew["com.mongodb.MongoClient", host, port]] | |||
| ] | |||
|
|
|||
| OpenConnection[host_String, port_Integer, "", _, _]:= OpenConnection[host, port] | |||
There was a problem hiding this comment.
What's the use case for this overload? Having a blank string seems to make it very specific, or is that standard for indicating anonymous authentication?
There was a problem hiding this comment.
@zbjornson you got the point. When you want anonymous authentication, you can still use OpenConnection with 5 parameters, using user as "". In my case, I read these parameters from a txt file, and I can still read the same number of fields to use OpenConnection, even for anonymous case. Using user -> "", pass -> "" , base -> "". And what matter is the user.
|
Thanks for the PR! |
|
@zbjornson Thank you for MongoDBLink, It's a very useful package. I use a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Connection with Credential to connect using user and password. Tested in Mongo 3.2