Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports with different protocols are marked as duplicate by no-duplicate-exported-ports #91

Closed
depado opened this issue Dec 28, 2024 · 4 comments · Fixed by #93
Closed
Assignees
Labels
bug Something isn't working released

Comments

@depado
Copy link

depado commented Dec 28, 2024

First of all, thanks for the great tool, it works amazing!

Version

2.2.1

YAML file where the error occurs

services:
  myservice:
    # ...
    ports:
      - '127.0.0.1:8388:8388/tcp'
      - '127.0.0.1:8388:8388/udp'
      - '127.0.0.1:8888:8888/tcp'

Command used to run

$ npx dclint compose.yml

Current behavior (console output)

/path/to/compose.yml
  54:1     error  Service "myservice" is exporting port "8388" which is already used by service "myservice".  no-duplicate-exported-ports

✖ 1 problems (1 errors, 0 warnings)

Expected behavior

As those ports don't use the same protocol, they shouldn't be marked as duplicated (as far as I understand). Avoiding the issue is very easy by just disabling this rule for this ports key, but it's still counter-intuitive I'd say?

@depado depado added the bug Something isn't working label Dec 28, 2024
@zavoloklom zavoloklom self-assigned this Dec 30, 2024
@zavoloklom
Copy link
Owner

@depado Hi! Thank you for your report, I'll fix it within a week. Or you can create PR :)

@zavoloklom
Copy link
Owner

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zavoloklom
Copy link
Owner

@depado
Thank you once again for the report! Feel free to reach out if you find any other bugs or if you have suggestions on how to make the utility better and more useful.

@depado
Copy link
Author

depado commented Jan 1, 2025

So quick! Thanks a lot!
And happy new year 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants