-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zarr.js #21
Add zarr.js #21
Conversation
Tests are passing for
I think this has something to do with the default |
Very good stuff! I notice things aren't really set up for reading with non-Python languages. Happy to get this merged while some thought is put into that. |
@manzt looks great! I think this is good to be merged, any objections?
Indeed, we should add read tests for other languages. |
No objections on my end! |
#19 @joshmoore @jakirkham
This PR adds a node-js based zarr writer for
zarr.js
. An important note is that due to the many runtime environments for JavaScript, there is no defaultFSStore
in Zarr.js. This is because each runtime environment (e.g. node, deno, and web-browsers) provide different APIs for interfacing with the file system. Zarr.js doesn't rely on any platform specific APIs, which makes it more portable as a library, but I had to add a minimalFSStore
implementation to this repo to enable writing to disk.As a side note, I found the ergonomics of the zarr.js API for creating stores to not be very user friendly. This is probably because
zarr.js
use-cases are almost entirelyread-only
in the web-browser. It is probably ideal to addzarr.js
as a reader (in a browser environment), but I'm not sure what steps to take in that direction given thepytest
env.