Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_dim_separator.py Generate fixtures when needed #824

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

joshmoore
Copy link
Member

@pep8speaks
Copy link

pep8speaks commented Aug 26, 2021

Hello @joshmoore! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-26 08:48:47 UTC

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #824 (9ee7966) into master (acf6828) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          31       31           
  Lines       10606    10609    +3     
=======================================
+ Hits        10600    10603    +3     
  Misses          6        6           
Impacted Files Coverage Δ
zarr/tests/test_dim_separator.py 100.00% <100.00%> (ø)

@joshmoore joshmoore merged commit 3a64977 into zarr-developers:master Aug 26, 2021
@joshmoore joshmoore deleted the gen-fixture branch August 26, 2021 09:40
joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Sep 26, 2022
Following the pattern from zarr-developers#824, this generates the
fixture test if it does not exist so that tests will
pass on conda-forge.

see: conda-forge/zarr-feedstock#65
joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Sep 26, 2022
Following the pattern from zarr-developers#824, this generates the
fixture test if it does not exist so that tests will
pass on conda-forge.

see: conda-forge/zarr-feedstock#65
joshmoore added a commit that referenced this pull request Sep 26, 2022
* 2.13.1: generate fixture/meta in conda tests

Following the pattern from #824, this generates the
fixture test if it does not exist so that tests will
pass on conda-forge.

see: conda-forge/zarr-feedstock#65

* Fix rst link

* Fix rst link again

* Add pragma: no cover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants