Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc release notes #616

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Misc release notes #616

merged 3 commits into from
Oct 6, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Sep 23, 2020

Misc addition to release notes.
I've also tagged all the PRs merged since 2.4 with the 2.5 milestone.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@alimanfoo alimanfoo added this to the v2.5 milestone Sep 24, 2020
@alimanfoo alimanfoo mentioned this pull request Sep 24, 2020
Closed
jakirkham
jakirkham approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the updated notes, it appears we have everything here. Multiget appears listed below and so does the removal of error functions. Maybe I was looking at an outdated diff before? Anyways this looks good on my end. Thanks Matthias! 😄

docs/release.rst Outdated Show resolved Hide resolved
@jakirkham jakirkham mentioned this pull request Oct 2, 2020
Merged
6 tasks
@Carreau
Copy link
Contributor Author

Carreau commented Oct 6, 2020

Travis CI appear twice (one green, one orange) and the orange one seem to be a bug as te URL is the same as the passing one.
I'll override and merge.

@Carreau Carreau merged commit 40e0011 into zarr-developers:master Oct 6, 2020
@Carreau Carreau deleted the rn branch October 6, 2020 01:53
@jakirkham
Copy link
Member

Interesting was wondering if this was the leftover travis-ci.org project, but going to that link it shows the project as migrated to travis-ci.com. Not sure why the other build showed up.

Visiting the associated pending Travis CI detail link shows it as passing as well. So it may just be the GitHub status API didn't work when updating the build as passed.

Anyways all this to say ignoring it seems fine and I also don't have any clue why it showed up 😅

@Carreau
Copy link
Contributor Author

Carreau commented Oct 6, 2020

it's not the first time I see that. So 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Carreau @jakirkham @alimanfoo