Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more setitem property tests #2825

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Add more setitem property tests #2825

merged 4 commits into from
Feb 14, 2025

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Feb 13, 2025 •
edited
Loading

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 13, 2025
@dcherian dcherian marked this pull request as draft February 13, 2025 16:41
@dcherian dcherian mentioned this pull request Feb 14, 2025
Open
@dcherian dcherian force-pushed the add-setitem-property-test branch from d4d16bf to 7fd4b14 Compare February 14, 2025 17:56
@dcherian dcherian marked this pull request as ready for review February 14, 2025 18:13
@d-v-b d-v-b merged commit 23abb5b into zarr-developers:main Feb 14, 2025
30 checks passed
@dcherian dcherian deleted the add-setitem-property-test branch February 14, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @d-v-b