Add Array metadata strategy #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
dcherian
commented
Feb 10, 2025
| @@ -85,12 +91,64 @@ def safe_unicode_for_dtype(dtype: np.dtype[np.str_]) -> st.SearchStrategy[str]: | |||
| # st.builds will only call a new store constructor for different keyword arguments | |||
| # i.e. stores.examples() will always return the same object per Store class. | |||
| # So we map a clear to reset the store. | |||
| stores = st.builds(MemoryStore, st.just({})).map(lambda x: sync(x.clear())) | |||
| stores = st.builds(MemoryStore, st.just({})).map(clear_store) | |||
There was a problem hiding this comment.
@maxrjones apparently this is only returning None today 🤦🏾♂️
dcherian
force-pushed
the
array-metadata-strategy
branch
from
67d4521 to
01dbceb
Compare
github-actions
bot
removed
the
needs release notes
dcherian
force-pushed
the
array-metadata-strategy
branch
from
01dbceb to
f9a3492
Compare
|
Thanks @dcherian ! This looks potentially very useful for zarr-developers/VirtualiZarr#9 |
d-v-b
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this useful for icechunk and presumably will be useful in virtualizarr (zarr-developers/VirtualiZarr#429 (review))
cc @TomNicholas @AimeeB @moradology
TODO:
docs/user-guide/*.rstchanges/