Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test for codec overwriting. #2811

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Regression test for codec overwriting. #2811

merged 6 commits into from
Feb 10, 2025

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Feb 10, 2025 •
edited
Loading

Fix is in upstream zarr-developers/numcodecs#700
Closes #2800

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 10, 2025
@dcherian dcherian force-pushed the fix-numcodecs-overwrite branch from 9fbecd9 to 2764f57 Compare February 10, 2025 15:53
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Feb 10, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Feb 10, 2025

looks good, merge at will

@dcherian dcherian enabled auto-merge (squash) February 10, 2025 15:57
@dcherian dcherian merged commit f4278a5 into zarr-developers:main Feb 10, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zarr overwrites codec configuration when creating and opening Arrays
2 participants
@dcherian @d-v-b