-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implicit fill value initialisation #2799
Conversation
- initialise empty chunks to the default fill value during writing - add default fill value for datetime, timedelta, structured data types
@@ -349,6 +349,14 @@ def _default_fill_value(dtype: np.dtype[Any]) -> Any: | |||
return b"" | |||
elif dtype.kind in "UO": | |||
return "" | |||
elif dtype.kind in "Mm": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use some keen eyes, I've never used these dtypes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also unfamiliar with those dtypes. perhaps you could find examples from the tests on the v2 branch?
45e7bd2
to
077a1ba
Compare
Fixes omissions in #2274
Fixes the below:
TODO:
docs/user-guide/*.rst
changes/