Update pull request template #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
approved these changes
Jan 15, 2025
maxrjones
pushed a commit
to maxrjones/zarr-python
that referenced
this pull request
Jan 16, 2025
d-v-b
added a commit
that referenced
this pull request
Jan 25, 2025
* Run Store tests on logging * Run store tests on wrapper * Add read only open tests to WrapperStore * Ignore new coverage files * Simplify wrapper tests * Fix __eq__ method in WrapperStore * Implement __repr__ for WrapperStore * Allow separate open and init kwargs * Add open class method to LoggingStore * Add __str__ to WrapperStore * Add repr test for LoggingStore * Fix __eq__ in LoggingStore * Test getsize for stores * Test for invalid ByteRequest * Use stdout rather than stderr as the default logging stream * Test default logging stream * Add test for getsize_prefix * Document buffer prototype parameter * Add test for invalid modes in StorePath.open() * Add test for contains_group * Add tests for contains_array * Test for invalid root type for LocalStore * Test LocalStore.get with default prototype * Test for invalid set buffer arguments * Test get and set on closed stores * Test using stores in a context manager * Specify abstract methods for StoreTests * Apply suggestions from code review Co-authored-by: Davis Bennett <[email protected]> * Lint * Fix typing for LoggingStore Co-authored-by: Davis Bennett <[email protected]> * Match specific Errors in tests Co-authored-by: Davis Bennett <[email protected]> * Add docstring Co-authored-by: Davis Bennett <[email protected]> * Parametrize tests Co-authored-by: Davis Bennett <[email protected]> * Test for contains group/array at multiple heirarchies Co-authored-by: Davis Bennett <[email protected]> * Update TypeError on GpuMemoryStore * Don't implement _is_open setter on wrapped stores * Update reprs for LoggingStore and WrapperStore * Test check_writeable and close for WrapperStore * Update pull request template (#2717) * Add release notes * Comprehensive changelog entry * Match error message * Apply suggestions from code review Co-authored-by: David Stansby <[email protected]> * Update 2693.bugfix.rst --------- Co-authored-by: Davis Bennett <[email protected]> Co-authored-by: Hannes Spitz <[email protected]> Co-authored-by: David Stansby <[email protected]> Co-authored-by: Joe Hamman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates PR template for new location of
docs/release-notes.rstanddocs/user-guide/*.rst