Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruff to 0.9.1 #2703

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jan 14, 2025

  • Fix RUF100 new warnings (E402 unused).
  • Enable ISC001/ISC002 since the documentation now states that they are compatible with the ruff formatter if used together:

    When using Ruff as a formatter, we recommend avoiding the following lint rules:
    [...]
    multi-line-implicit-string-concatenation (ISC002) if used without ISC001 and flake8-implicit-str-concat.allow-multiline = false

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

RUF100 Unused `noqa` directive (unused: `E402`)

Otherwise, latest ruff 0.9.1 complains.
Starting with ruff 0.9.1, they are documented to be compatible with the
ruff formatter, if they are both enabled.
@dstansby dstansby enabled auto-merge (squash) January 16, 2025 11:06
@dstansby dstansby merged commit 280daac into zarr-developers:main Jan 16, 2025
29 of 30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the RUF100_E402 branch January 16, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants