Zarr v2 + Zstd: Don't persist the checksum param if false #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jhamman
approved these changes
Jan 6, 2025
jhamman
reviewed
Jan 6, 2025
Comment on lines
+121
to
+123
| # Hotfix for https://github.com/zarr-developers/zarr-python/issues/2647 | ||
| if codec_config["id"] == "zstd" and not codec_config.get("checksum", False): | ||
| codec_config.pop("checksum", None) |
There was a problem hiding this comment.
feels a bit wrong but I don't think this hurts anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the zstd codec to not persist the checksum param, if it is set to False (the default). This is aimed at improving backwards compatibility.
See #2647 (comment)
Fixes #2647