Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception docs #2624

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Improve exception docs #2624

merged 3 commits into from
Jan 3, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jan 2, 2025 •
edited
Loading

  • Add all the exceptions to __all__
  • Make BaseZarrError public, since it's inherited by all the other public classes.
  • Add docstrings (otherwise these just inherit the default ValueError docstring)

@jhamman jhamman enabled auto-merge (squash) January 2, 2025 23:52
@jhamman jhamman merged commit c070940 into zarr-developers:main Jan 3, 2025
27 checks passed
@dstansby dstansby deleted the exception-docs branch January 3, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @dcherian @jhamman