Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add packaging to required deps #2573

Merged
merged 3 commits into from
Dec 19, 2024
Merged

deps: add packaging to required deps #2573

merged 3 commits into from
Dec 19, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Dec 18, 2024 •
edited
Loading

Closes #2487

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman requested a review from dstansby December 18, 2024 16:59
@jhamman
Copy link
Member Author

jhamman commented Dec 18, 2024

Any ideas why mypy is failing here?

@dstansby
Copy link
Contributor

At a glance and a guess, a change in recently-released numpy 2.2?

@jhamman jhamman mentioned this pull request Dec 18, 2024
Open
@jhamman
Copy link
Member Author

jhamman commented Dec 18, 2024

@dstansby - I've pinned numpy in our precommit/mypy config now and reported the regression upstream.

@dstansby dstansby merged commit 5bf7bcf into zarr-developers:main Dec 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing packaging dependency
2 participants
@jhamman @dstansby