Exclude bad version of numcodecs & fix bsddb3 doctests #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
approved these changes
Dec 8, 2024
Actually exclude bad version of numcodecs Fix changelog entry
Fix doctest requires Try bumping version of pytest-doctestplus Fixup doctest requires
dstansby
force-pushed
the
bad-numcodecs-pin
branch
from
511d341 to
b55446d
Compare
dstansby
changed the title
dstansby
changed the title
dstansby
force-pushed
the
bad-numcodecs-pin
branch
from
2b469ab to
c95d074
Compare
dstansby
force-pushed
the
bad-numcodecs-pin
branch
from
c95d074 to
e52e1a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## support/v2 #2544 +/- ##
==============================================
- Coverage 99.98% 99.95% -0.03%
==============================================
Files 38 38
Lines 14718 14664 -54
==============================================
- Hits 14716 14658 -58
- Misses 2 6 +4
|
dstansby
changed the title
|
Sigh, numpy 2.2 is breaking some tests. I've pinned it here, I recommend we merge this and then I can tackle the numpy 2.2. breakages in another PR and un-pin it there. |
|
can you explain a bit why the |
|
Sorry, originally I dropped support for bsddb3 in #2344 (see changelog entry in that PR) because it wasn't playing nicely with numpy v2, and I didn't think it worth the time to invest in fixing for zarr v2. In that PR I forgot to delete the tests, so I've done that here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zarr-developers/numcodecs#653 for context. This should make tests run again on the v2 branch.
Also fixes some parts of #2344 that were broken regarding skipping the bsddb3 doctests (I'm not sure why tests didn't run in that PR...)