-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up optional dependency groups #2541
Conversation
ffe3a95
to
f464acb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just one suggestion.
For groups with only one optional dependency, I think its best if we just use the dependency as the name.
Is there any benefit in having a dependency group where the name is the same as the package? I'd suggest we either
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any benefit in having a dependency group where the name is the same as the package? I'd suggest we either
- leave it as
tree
, to indicate "install this extra if you want to usetree()
If we do this, we should adopt the "feature-oriented groups" approach for the other groups as well. That would apply to fsspec for RemoteStore
.
- remove it altogether and just document that folks need to install
rich
to usetree()
I favor this option actually for rich
and universal-pathlib
.
f9341c5
to
e1478cc
Compare
d5548e7
to
f8734b5
Compare
pre-commit.ci autofix |
👍 done. I also removed universal-pathlib, tree, and started a v3 what's new (I don't think this already exists?) to communicate what's changed from v2. |
Fixes #2539.