Feat/concurrent members #2519
Open
Feat/concurrent members #2519
+382
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/concurrent-members
…at/concurrent-members
|
note: this PR depends on #2474 |
d-v-b
requested review from
jhamman and
TomAugspurger
and removed request for
jhamman
dcherian
reviewed
Dec 12, 2024
dcherian
reviewed
Dec 12, 2024
dcherian
reviewed
Dec 12, 2024
dcherian
reviewed
Dec 12, 2024
|
|
||
|
|
||
| @pytest.mark.parametrize("store", ["memory"], indirect=True) | ||
| def test_group_members_performance(store: MemoryStore) -> None: |
Co-authored-by: Deepak Cherian <[email protected]>
…at/concurrent-members
…n into feat/concurrent-members
…ess than the number of groups * latency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
AsyncGroup.members()fetch keys and fetch metadata concurrently, which provides a big performance win for high-latency storage backends. The number of concurrent operations is limited by the zarr-wide configuration setting.in
main,Group.members()requires~O(num_members)time to complete, because it does not perform IO concurrently. In this PR,Group.membersruns in constant time (until the number of concurrent requests exceeds the concurrency limit).