Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Store.getsize is a thing, we can do info_complete which includes the number of chunks written and the size of those bytes.
The current implementation unfortunately does two
list_prefix
es on the same prefix. The first to get the count of chunks initialized and the second to get the bytes stored under a prefix. Unfortunately, these down compose well. I haven't thought of a nice way to eliminate that yet. We can do this naively by doing a singlelist_prefix
and then counting the number of keys as we callgetsize
on each. But we also have aStore.getsize_prefix
for those stores that have fastpaths for getting the total number of bytes under a prefix. I don't really want aStore.getsize_and_count_prefix
, but maybe some kind ofStore.statistics_prefix
? Probably not worth worrying about today.