[v3] Array.append #2413
Merged
[v3] Array.append #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes the Array.resize to be an inplace operation
…into feature/append-v3
jhamman
commented
Oct 19, 2024
| return replace(self, metadata=new_metadata) | ||
|
|
||
| # Update metadata (in place) | ||
| object.__setattr__(self, "metadata", new_metadata) |
There was a problem hiding this comment.
@TomAugspurger - calling this out because it will impact the xarray use of resize... now in-place again :)
d-v-b
reviewed
Oct 20, 2024
d-v-b
reviewed
Oct 20, 2024
Comment on lines
+422
to
+424
| @pytest.mark.parametrize("store", ["memory"], indirect=True) | ||
| @pytest.mark.parametrize("zarr_format", [2, 3]) | ||
| def test_resize_1d(store: MemoryStore, zarr_format: int) -> None: |
There was a problem hiding this comment.
to fight test bloat we should find a way to parameterize over dimensionality instead of making separate 1d, 2d, etc tests. but that's not a blocker here.
There was a problem hiding this comment.
agree! These tests were copied over from v2 so I'm going to leave them for now.
…into feature/append-v3
|
pre-commit.ci autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the
Array.appendmethod over from 2.18 (plus tests for resize/append). Mostly a copy-and-paste but does come with a bit of extra behavior changes:Arrayclass is now a non-Frozen dataclass. This is needed to support property setters. I've added a note describing when we can go back tofrozen=TrueArray.resizeis an in-place op again. As we discussed at the meeting yesterday, it really didn't make sense to have this any other way (what would you do with the old array object?)closes #2404
TODO: