Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore extra keys in v2 metadata #2297

Merged

Conversation

TomAugspurger
Copy link
Contributor

Ignore unexpected keys in Zarr V2 metadata, to enable reading zarr files written by other systems, which might store additional data in the top level of the .zgroup and .zarray files`

Closes #2296

Ignore unexpected keys in Zarr V2 metadata, to enable reading zarr
files written by other systems, which might store additional data
in the top level of the `.zgroup` and `.zarray` files`

Closes zarr-developers#2296
@TomAugspurger TomAugspurger marked this pull request as ready for review October 2, 2024 15:07
@d-v-b
Copy link
Contributor

d-v-b commented Oct 2, 2024

I checked and the spec says we SHOULD be doing this :)

Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TomAugspurger TomAugspurger merged commit f13e954 into zarr-developers:v3 Oct 2, 2024
20 checks passed
@TomAugspurger TomAugspurger deleted the tom/fix/ignore-extra-keys branch October 2, 2024 19:28
@jhamman jhamman added the V3 label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupMetadata and ArrayV2Metadata should ignore extra keys for zarr v2 metadata
3 participants