Change ArrayV3Metadata.data_type to DataType #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabernat
changed the title
d-v-b
reviewed
Oct 1, 2024
src/zarr/core/metadata/v3.py
Outdated
| @@ -490,8 +492,11 @@ def to_numpy_shortname(self) -> str: | |||
| } | |||
| return data_type_to_numpy[self] | |||
|
|
|||
| def to_numpy_dtype(self) -> np.dtype[Any]: | |||
There was a problem hiding this comment.
I could see to_numpy as a slightly briefer name for this method
There was a problem hiding this comment.
I kind of prefer it more explicit, but I suppose that information is in the type annotation, so ok.
d-v-b
reviewed
Oct 1, 2024
src/zarr/core/metadata/v3.py
Outdated
| @classmethod | ||
| def from_dtype(cls, dtype: np.dtype[Any]) -> DataType: | ||
| def from_numpy_dtype(cls, dtype: np.dtype[Any]) -> DataType: |
There was a problem hiding this comment.
d-v-b
reviewed
Oct 1, 2024
d-v-b
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on #2036, I realized that the current treatment of the
data_typeattribute in V3 metadata was somewhat inconsistent. This class is meant to represent the Zarr metadata in an abstract way, in alignment with the spec. However, it was just using numpy dtypes internally.This becomes a problem when we want to support dtypes that are not numpy dtypes, like
string.This PR changes the
ArrayV3Metadataclass such that the type ofdata_typeis the existingDataTypeenum. However, I've kept the.dtypeproperty returning a numpy dtype. This allows this change to be minimally disruptive to other parts of the code.