[v3] Implement Group methods for empty, full, ones, and zeros #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindseynield
commented
Sep 18, 2024
| empty_array = group.empty(shape=shape) | ||
| assert isinstance(empty_array, Array) | ||
| assert empty_array.fill_value == 0 | ||
| assert empty_array.shape == shape |
There was a problem hiding this comment.
Fill value expected to be 0: https://github.com/zarr-developers/zarr-python/blob/v3/src/zarr/core/array.py#L253-L257
jhamman
reviewed
Sep 18, 2024
jhamman
reviewed
Sep 18, 2024
jhamman
approved these changes
Sep 19, 2024
|
Thanks @lindseynield and welcome to the Zarr project! |
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Sep 24, 2024
* v3: chore: update pre-commit hooks (zarr-developers#2222) fix: validate v3 dtypes when loading/creating v3 metadata (zarr-developers#2209) fix typo in store integration test (zarr-developers#2223) Basic Zarr-python 2.x compatibility changes (zarr-developers#2098) Make Group.arrays, groups compatible with v2 (zarr-developers#2213) Typing fixes to test_indexing (zarr-developers#2193) Default to RemoteStore for fsspec URIs (zarr-developers#2198) Make MemoryStore serialiazable (zarr-developers#2204) [v3] Implement Group methods for empty, full, ones, and zeros (zarr-developers#2210) implement `store.list_prefix` and `store._set_many` (zarr-developers#2064) Fixed codec for v2 data with no fill value (zarr-developers#2207)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Group.{empty,zeros,ones,full,empty_like, zeros_like,onest_like,full_like}for V3. Here we simply call the top-level functions fromzarr.api.asynchronousto accomplish this.Closes #2125
TODO: