Handle fill_value for bytes dtype #2208
Closed
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly fixes how we handle
bytes
dtype arrays. Pushing up early for a bit of a discussion around the spec:AFAICT,
bytes
aren't a "required"(?) dtype for zarr v3. From https://zarr-specs.readthedocs.io/en/latest/v3/core/v3.0.html#fill-value:So the proper way to do this would be to