Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify mypy config for tests #2156

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Simplify mypy config for tests #2156

merged 6 commits into from
Sep 11, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Sep 8, 2024

This builds on #2150 (cc @TomAugspurger) to:

  • move the config for mypy type checking tests from pre-commit-config.yaml to pyproject.toml, so mypy run outside of pre-commit also picks up the config.
  • Add an explicit list of tests to ignore errors for (which we can fix one by one)
  • Make some low hanging typing fixes to the tests

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman merged commit 726fdfb into zarr-developers:v3 Sep 11, 2024
26 checks passed
@dstansby dstansby deleted the mypy-testss branch September 11, 2024 08:36
dcherian added a commit to dcherian/zarr-python that referenced this pull request Sep 16, 2024
@dcherian
Merge branch 'v3' into fix-hypothesis-complex-warning
a8de6d6 
* v3:
  fix: opening a group with unspecified format finds either v2 or v3 (zarr-developers#2183)
  test: check that store, array, and group classes are serializable  (zarr-developers#2006)
  feature(store): V3 ZipStore (zarr-developers#2078)
  More typing fixes for tests (zarr-developers#2173)
  refactor: split metadata into v2 and v3 modules (zarr-developers#2163)
  Accept dictionaries for `store` argument (zarr-developers#2164)
  Simplify mypy config for tests (zarr-developers#2156)
  Fixed path segment duplication in open_array (zarr-developers#2167)
  Fixed test warnings (zarr-developers#2168)
  chore: update pre-commit hooks (zarr-developers#2165)
  Ensure that store_dict used for empty dicts (zarr-developers#2162)
  Bump pypa/gh-action-pypi-publish from 1.10.0 to 1.10.1 in the actions group (zarr-developers#2160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @TomAugspurger @jhamman