Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
string
andbytes
dtypes plusvlen-utf8
andvlen-bytes
codecs #2036Add
string
andbytes
dtypes plusvlen-utf8
andvlen-bytes
codecs #2036Changes from 30 commits
c05b9d1
c86ddc6
a322124
2a1e2e3
1d3d7a5
cd40b08
988f9df
507161a
1ae5e63
94ecdb5
2c7d638
b1717d8
79b7d43
a5c2a37
717f0c7
b90d8f3
0406ea1
8e61a18
6cf7dde
28d58fa
c6de878
4f026db
e427c7a
7d9d897
0c21994
c12ac41
3aeea1e
cae7055
1aeb49a
6714bad
2edf3b8
12a0d65
7ba7077
1e828b4
ba0f093
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought I had while implementing this: often the original numpy array is a fixed-length type (e.g.
<U5
). In V2, this dtype could be stored directly in the metadata, whereas now we are losing the5
, which is potentially useful information.In the future, we may want to try to resurface this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're OK.
I think that it just does some tricks with the strides or something?