Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] array tests: handle different hexdigests from zlib-ng (#1678) #1971

Closed
wants to merge 2 commits into from

Conversation

AdamWill
Copy link

As explained in the issue, zlib-ng produces different hex digests from original zlib. This adjusts the tests slightly to allow for this.

TODO:

  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Removed TODO items are irrelevant as this only changes tests.

…pers#1678)

As explained in the issue, zlib-ng produces different hex digests
from original zlib. This adjusts the tests slightly to allow for
this.

Signed-off-by: Adam Williamson <[email protected]>
@AdamWill AdamWill force-pushed the array-hexdigest-zlibng branch from e52419d to e25f93d Compare June 17, 2024 18:45
@dstansby dstansby changed the title v2 array tests: handle different hexdigests from zlib-ng (#1678) [v3] array tests: handle different hexdigests from zlib-ng (#1678) Sep 6, 2024
@jhamman jhamman added V2 Affects the v2 branch V3 and removed V2 Affects the v2 branch labels Oct 11, 2024
@jhamman
Copy link
Member

jhamman commented Oct 11, 2024

Closing as stale (the modified file has been removed in v3)

@jhamman jhamman closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants