Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest to mypy dependencies #1846

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 7, 2024

If/when we start type checking tests, this will be needed to give mypy type information from pytest. See also #1844 (comment).

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b
Copy link
Contributor

d-v-b commented May 7, 2024

If/when we start type checking test

Yes and immediately :)

@joshmoore
Copy link
Member

👍 from my side. I went looking whether dependencies need to be re-hardcoded but pre-commit/pre-commit#730 (comment) is pretty definitive:

pre-commit does not install from the repository under test. period. doing so makes caching intractable

@jhamman
Copy link
Member

jhamman commented May 7, 2024

Amazing! Thank you @dstansby!

@jhamman jhamman merged commit 7e944f0 into zarr-developers:v3 May 7, 2024
18 checks passed
@dstansby dstansby deleted the pytest-mypy branch May 7, 2024 15:00
@jhamman jhamman added the V3 label May 15, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 15, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants