Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic typing in zarr.codecs #1845

Closed
wants to merge 1 commit into from
Closed

Fix generic typing in zarr.codecs #1845

wants to merge 1 commit into from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 7, 2024

This finishes typing generic types in zarr.codecs. There's still one issue that needs fixing...

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@MSanKeys963 MSanKeys963 added the V3 label May 8, 2024
@dstansby dstansby force-pushed the code-any-generics branch 2 times, most recently from 2a4e1d4 to 7f50621 Compare May 10, 2024 09:31
@dstansby dstansby force-pushed the code-any-generics branch from 7f50621 to a25bad6 Compare May 10, 2024 15:38
@dstansby dstansby marked this pull request as ready for review May 10, 2024 15:48
@jhamman jhamman requested a review from normanrz May 14, 2024 03:27
@normanrz
Copy link
Member

Hi David, thanks for working on this. I think it is important to get extensive mypy coverage in the 3.0 release.
However, I have rewritten large parts of the affected code in #1670. Additionally, #1826 will change most of these signatures to new generalized buffer classes. I'm afraid we'll have to pause this PR until that work is complete.

@dstansby
Copy link
Contributor Author

No worries, thanks for letting me know - shall we close this PR then?

@normanrz
Copy link
Member

normanrz commented May 15, 2024 •
edited
Loading

Yeah. I guess that makes sense. Thanks again!

@normanrz normanrz closed this May 15, 2024
@dstansby dstansby deleted the code-any-generics branch May 15, 2024 19:20
@jhamman jhamman added the types label Jun 1, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz Awaiting requested review from normanrz

Assignees
No one assigned
Labels
types
Projects
None yet
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @normanrz @jhamman @MSanKeys963