Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object-store
-based Store implementation #1661base: main
Are you sure you want to change the base?
object-store
-based Store implementation #1661Changes from 3 commits
14be826
a492bf0
50b6c47
afa79af
c466f9f
c3e7296
f5c884b
af2a39b
d7cfbee
cb40015
619df43
b976450
cca70d7
f2c827d
5c8903f
50e1dec
8bb252e
559eafd
5486e69
9a05c01
56b7a0b
d5d0d4d
b38ada1
ab00b46
9c65e4d
77d7c12
4418426
7a71174
e73bcc9
c2cd6b8
a95ec59
fb8b16d
ca261b1
0eb416a
247432f
4b31b3c
d49d1ff
c2ebc8f
eb76698
f310260
86951b8
f989884
40e1b25
3aa3578
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How I did it in rfsspec: https://github.com/martindurant/rfsspec/blob/main/src/lib.rs#L141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object-store has a built-in function for this:
get_ranges
. With the caveat that it only manages multiple ranges in a single file.get_ranges also automatically handles request merging for nearby ranges in a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know, but mine already did the whole thing, so I am showing how I did that.