Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary list literal → set literal #1534

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Unnecessary list literal → set literal #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8857eb3
Unnecessary list literal → set literal
DimitriPapadopoulos Sep 30, 2023
39877a2
Add release note for previous commit
DimitriPapadopoulos Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Unreleased
Maintenance
~~~~~~~~~~~

* Initialise some sets in tests with set literals instead of list literals.
By :user:`Dimitri Papadopoulos Orfanos <DimitriPapadopoulos>` :issue:`1534`.

* Allow ``black`` code formatter to be run with any Python version.
By :user:`David Stansby <dstansby>` :issue:`1549`

Expand Down
6 changes: 3 additions & 3 deletions zarr/tests/test_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,9 +1166,9 @@ def test_deep_ndim(self):
if self.version == 2:
assert set(store.listdir()) == {".zgroup", "bar"}
else:
assert set(store.listdir()) == set(["data", "meta", "zarr.json"])
assert set(store.listdir("meta/root/" + path)) == set(["bar", "bar.group.json"])
assert set(store.listdir("data/root/" + path)) == set(["bar"])
assert set(store.listdir()) == {"data", "meta", "zarr.json"}
assert set(store.listdir("meta/root/" + path)) == {"bar", "bar.group.json"}
assert set(store.listdir("data/root/" + path)) == {"bar"}
assert foo["bar"]["baz"][(0, 0, 0)] == 1

def test_not_fsspec(self):
Expand Down