Sharding storage transformer for v3 #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gregory Lee <[email protected]>
Co-authored-by: Gregory Lee <[email protected]>
jstriebel
changed the title
…-storage-transformer
Codecov Report
@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 35 36 +1
Lines 14410 14739 +329
==========================================
+ Hits 14410 14739 +329
|
|
This pull request introduces 2 alerts when merging 06ce675 into 44de0e4 - view on LGTM.com new alerts:
|
…t-set' into sharding-storage-transformer
|
@joshmoore I just added a |
…and-partial-get-set
…-get-set Storage transformers and partial get set
joshmoore
added a commit
that referenced
this pull request
Jan 16, 2023
* add storage_transformers and get/set_partial_values * formatting * add docs and release notes * add test_core testcase * Update zarr/creation.py Co-authored-by: Gregory Lee <[email protected]> * apply PR feedback * add comment that storage_transformers=None is the same as storage_transformers=[] * use empty tuple as default for storage_transformers * make mypy happy * better coverage, minor fix, adding rmdir * add missing rmdir to test * increase coverage * improve test coverage * fix TestArrayWithStorageTransformersV3 * Update zarr/creation.py Co-authored-by: Gregory Lee <[email protected]> * pick generic storage transformer changes from #1111 * increase coverage * fix order of storage transformers * retrigger CI * minor fixes * make flake8 happy * apply PR feedback Co-authored-by: Gregory Lee <[email protected]> Co-authored-by: Josh Moore <[email protected]>
|
@jstriebel : ok to leave you to push the update here? (If not, I'll dig in) |
…t-set' into sharding-storage-transformer
Sure, done 👍 |
6 tasks
joshmoore
approved these changes
Jan 23, 2023
🚀
Seems fine to me 👍 |
|
@joshmoore I don't see any further actionables for this PR, I'd be glad if we could merge it soon. |
rabernat
approved these changes
Feb 2, 2023
|
Yessirs. |
|
This is huge! 🙌 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
(a more efficient implementation might be a good follow-up)
(some refactoring might be needed in
core.pyto simplify the code-paths, but I'd rather defer this to a separate PR to keep the diff readable)TODO:
New/modified features documented in docs/tutorial.rst(v3 is not yet documented)