Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing preparation #3

Merged
merged 21 commits into from
Jul 4, 2024

Conversation

brokkoli71
Copy link
Member

  • created deploy.yml for deployment pipeline
  • signing with GPG
  • prepare pom.xml for publishing

brokkoli71 and others added 6 commits June 3, 2024 23:30
* add zarrita python script

* add testReadFromZarrita

* renamed zarrita_write

* add testWriteToZarrita

* parameterized codecs in testReadFromZarrita

* fixed camelcase in zarr.json

* add venv for executing zarrita in linux

* adapt test-setup for linux

* adapt test-setup for linux

* fix testReadFromZarrita for gzip

* parameterize codecs in testReadFromZarrita

* remove unused imports

* add testCodecsWriteRead

* reformat

* remove unnecessary argument

* add testCodecTranspose

* start remove constants "C" adn "F" from Transpose Codec's order

* add CoreArrayMetadata to codec object instead of passing as argument in encode and decode
remove transpose order "F" and "C"

* remove wrong dependency

* set fail-fast: false

* specify testSourceDirectory

* added property index_location to ShardingIndexedCodec

* add indexLocation in ShardingCodec.

* change junit version for TestUtils

* remove creation of dir testdata

* update dependencies for JUnit 5

* install zarrita in CI

* correct python version, maven no-transfer-progress

* add venv for executing zarrita to CI

* add /venv_zarrita to .gitignore

* remove deprecated zarrita venv

* test CI

* fix tests for windows

* update python path for windows in ci.yml

* add Development Start-Guide to Run Tests Locally

* correct Development Start-Guide to python3.11

* add support of shardingCodec indexLocation=start

* code cleanup

* add testZstdLibrary

* fix Zstd compression and decompression

* cleanup code

* cleanup code

* remove unused method

* include crc32c codec into tests

* incorporate feedback for java version and merge tests

* add more variation to codec-configuration in tests with zarrita

* fix BloscCodec with shuffle = "shuffle"
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@brokkoli71 brokkoli71 marked this pull request as ready for review June 26, 2024 11:32
@normanrz
Copy link
Member

@sbesson What do you think about the name of the package for publishing? I remember you didn't like dev.zarr.zarrjava. We probably can't use just dev.zarr anymore.

@sbesson
Copy link
Contributor

sbesson commented Jun 27, 2024

We probably can't use just dev.zarr anymore.

I'd defer to @joshmoore and owners of the https://zarr.dev/ domain but my preference would have gone for dev.zarr as the groupId and zarr-java as the artifact ID. That would be consistent with https://github.com/zarr-developers/jzarr being published to dev.zarr:jzarr as well

@joshmoore
Copy link
Member

Ack. I did not see this! 🤦🏽 x2 today. I'm reviewing the diff between this and #4 now. Apologies, @brokkoli71.

@joshmoore
Copy link
Member

joshmoore commented Jul 4, 2024

@brokkoli71: apologies. Didn't realize there were no tests run on zarr-java2. My merge duplicated a tag:

[FATAL] Non-parseable POM /home/runner/work/zarr-java/zarr-java/pom.xml: Duplicated tag: 'name' (position: START_TAG seen ...</developers>\n\n    <name>... @44:11)  @ line 44, column 11

Could you remove or shall I open another PR?

@brokkoli71
Copy link
Member Author

Ack. I did not see this! 🤦🏽 x2 today. I'm reviewing the diff between this and #4 now. Apologies, @brokkoli71.

No worries, @joshmoore. Let me know if there's anything I can assist with.

@joshmoore joshmoore merged commit bdb1bb8 into zarr-developers:main Jul 4, 2024
3 checks passed
@brokkoli71 brokkoli71 deleted the publishing-preparation branch July 4, 2024 09:25
@joshmoore
Copy link
Member

@sbesson
Copy link
Contributor

sbesson commented Jul 4, 2024

https://repo1.maven.org/maven2/dev/zarr/zarr-java/0.0.2/ thanks all. We'll start consuming this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants