Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Use pyproject.toml to specify build requirements #129

Conversation

alimanfoo
Copy link
Member

[Description of PR]

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@@ -1,6 +1,7 @@
coverage
coveralls
flake8
py-cpuinfo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including this here because then it allows developers to run setup.py directly, e.g., python setup.py build_ext --inplace.

@alimanfoo
Copy link
Member Author

I'm running into issues getting this to work, e.g., tox does not pick up the build requirements in pyproject.toml, and appveyor (which doesn't use tox) has errors relating to setuptools-scm not creating version.py. I don't understand fully what's going on, so am going to back off for now and fall back to using setup_requires for py-cpuinfo, but will close and leave this PR as a record.

@alimanfoo
Copy link
Member Author

xref pypa/pip#5407

@alimanfoo alimanfoo closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant