open_virtual_dataset with and without indexes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
commented
Mar 26, 2024
Comment on lines
+51
to
69
| vds_refs = kerchunk.read_kerchunk_references_from_file( | ||
| filepath=filepath, | ||
| filetype=filetype, | ||
| ) | ||
|
|
||
| ds = dataset_from_kerchunk_refs( | ||
| ds_refs, | ||
| if indexes is None: | ||
| # add default indexes by reading data from file | ||
| # TODO we are reading a bunch of stuff we know we won't need here, e.g. all of the data variables... | ||
| # TODO it would also be nice if we could somehow consolidate this with the reading of the kerchunk references | ||
| ds = xr.open_dataset(filepath) | ||
| indexes = ds.xindexes | ||
| ds.close() | ||
|
|
||
| vds = dataset_from_kerchunk_refs( | ||
| vds_refs, | ||
| drop_variables=drop_variables, | ||
| virtual_array_class=virtual_array_class, | ||
| indexes=indexes, | ||
| ) |
There was a problem hiding this comment.
We're literally opening the file twice here - once with kerchunk to read all the byte ranges, and then optionally once again to read in the values to use to create defaut pandas indexes with xarray.
Wondering if you have any thoughts on how hard it might be to consolidate these @jhamman ?
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 88.12% 90.04% +1.91%
==========================================
Files 13 13
Lines 893 944 +51
==========================================
+ Hits 787 850 +63
+ Misses 106 94 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
This PR ensures that you can either create a virtual dataset with real in-memory pandas indexes using
open_virtual_dataset(..., indexes=None), or avoid creating indexes entirely usingopen_virtual_dataset(..., indexes={}). The kwarg signature here was chosen to match what is planned forxr.open_dataset, see pydata/xarray#6633.