Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand xarray openable type hint with ReadBuffer #316

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Nov 23, 2024

Should hopefully fix the typing error that appeared in the last few days, which I think is caused by pydata/xarray#9787 upstream.

(This does serve us right for importing private xarray internals...)

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@TomNicholas TomNicholas added the xarray Requires changes to xarray upstream label Nov 23, 2024
@TomNicholas
Copy link
Member Author

Even after going back and forth with ChatGPT I still can't work out what I'm supposed to do to get this type hint to work 😠

@TomNicholas
Copy link
Member Author

I gave up and just used # type: ignore[arg-type]

@TomNicholas TomNicholas merged commit fd05b7d into main Nov 23, 2024
11 checks passed
@TomNicholas TomNicholas deleted the fix_ReadBuffer_typing branch November 23, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing xarray Requires changes to xarray upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant