Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #275

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Update index.md #275

merged 1 commit into from
Oct 31, 2024

Conversation

thodson-usgs
Copy link
Contributor

Remove fsspec from xr.open_dataset usage example.

Did I misunderstand something? I thought we could just

ds = xr.open_dataset('combined.json', ...)

Remove `fsspec` from `xr.open_dataset` usage example.
@TomNicholas
Copy link
Member

Oh right yes - with engine='kerchunk' you don't need the fsspec mapper (because the kerchunk backend engine creates the mapper for you.

Soon I want to update these top-level examples to use icechunk instead though, which would just be

xr.open_zarr(icechunkstore)

@TomNicholas TomNicholas added the documentation Improvements or additions to documentation label Oct 25, 2024
@norlandrhagen
Copy link
Collaborator

Merging this for now, with the goal of replacing the default examples with icechunk

@norlandrhagen norlandrhagen merged commit 5e66ad0 into zarr-developers:main Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants