Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Xarray handle decode_times #232

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Let Xarray handle decode_times #232

merged 9 commits into from
Aug 27, 2024

Conversation

norlandrhagen
Copy link
Collaborator

@norlandrhagen norlandrhagen commented Aug 26, 2024 •
edited
Loading

@norlandrhagen norlandrhagen changed the title Decode times Let Xarray handle decode_times Aug 27, 2024
TomNicholas
TomNicholas reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This makes a lot more sense than having the cftime_variables kwarg.

docs/usage.md Outdated Show resolved Hide resolved
virtualizarr/tests/test_xarray.py Outdated Show resolved Hide resolved
virtualizarr/xarray.py Outdated Show resolved Hide resolved
@TomNicholas
Copy link
Member

@norlandrhagen I merged in the changes from main but there are failing tests when I try this locally...

@TomNicholas
Copy link
Member

TomNicholas commented Aug 27, 2024 •
edited
Loading

Thanks for fixing that @norlandrhagen ! Let's just add a note to the release notes to explain to users what we have just changed, then this should be good to merge.

Also FYI @jsignell

@TomNicholas TomNicholas merged commit d2f0d06 into main Aug 27, 2024
8 checks passed
@TomNicholas TomNicholas deleted the decode_times branch August 27, 2024 16:38
@norlandrhagen norlandrhagen mentioned this pull request Aug 27, 2024
Closed
jsignell
jsignell reviewed Sep 4, 2024
View reviewed changes
virtualizarr/backend.py
@@ -54,6 +53,7 @@ def open_virtual_dataset(
filetype: FileType | None = None,
drop_variables: Iterable[str] | None = None,
loadable_variables: Iterable[str] | None = None,
decode_times: bool | None = None,
cftime_variables: Iterable[str] | None = None,
Copy link
Contributor

@jsignell jsignell Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seeing this after getting back from break. Should the cftime_variables kwarg be removed?

EDIT: oohh I see it's being deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomNicholas TomNicholas TomNicholas left review comments

@jsignell jsignell jsignell left review comments

Assignees
No one assigned
Labels
CF conventions encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norlandrhagen @TomNicholas @jsignell