-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open_virtual_dataset with dmr++ #113
Merged
Merged
Changes from 10 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
18b53bd
basic dmr parsing functionality
ayushnag 47d8901
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f3bfa82
Merge branch 'TomNicholas:main' into dmr-adapter
ayushnag aaf6af2
Speedup DMR chunk key parsing
agoodm fc8b0d8
Merge pull request #1 from agoodm/dmr-adapter
ayushnag 7b81eeb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8334d0a
added groups, docs, and bug fixes
ayushnag 64d59b1
Merge branch 'TomNicholas:main' into dmr-adapter
ayushnag 1a3b787
Merge branch 'zarr-developers:main' into dmr-adapter
ayushnag 7580fdc
rework hdf5 parser and group logic
ayushnag 52ceba0
Merge remote-tracking branch 'upstream/main' into dmr-adapter
ayushnag b1f9aee
update attrs cast to python dtype
ayushnag ae29176
parser passing tests
ayushnag 6e763f9
match main manifest dtypes
ayushnag 0824ed2
Merge branch 'zarr-developers:main' into dmr-adapter
ayushnag 659ab65
Merge branch 'zarr-developers:main' into dmr-adapter
ayushnag b8531c8
Merge branch 'zarr-developers:main' into dmr-adapter
ayushnag 0125d71
Merge branch 'zarr-developers:main' into dmr-adapter
ayushnag ef8aa9c
modularize dmrpp.py
ayushnag 7638092
add dmrpp api docs
ayushnag 83cb586
resolve conflict
ayushnag cb6feff
resolve releases conflict
ayushnag 888ce32
indexes and docs fix
ayushnag 3e15e8e
Merge branch 'main' into dmr-adapter
TomNicholas ee23ec0
Fix type hint for shape
TomNicholas d9337ff
change how FileType is used
TomNicholas 6bb9218
Change FileType check again
TomNicholas d1948d4
fix storage_options bug
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The int32 to int64 change had to be made since I ran into some large byte offsets with the Atlas ICE-SAT dataset. Here is an example error:
OverflowError: Python integer 6751178683 out of bounds for int32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that justifies #177!