Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in broadcast_to logic #146

Closed
TomNicholas opened this issue Jun 18, 2024 · 1 comment
Closed

Bug in broadcast_to logic #146

TomNicholas opened this issue Jun 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TomNicholas
Copy link
Member

There is some kind of bug in my logic that implements broadcast_to for ManifestArrays backed by dicts - see 6d53d4c.

I think because we're about to replace that logic with #107 (which fixes the bug by delegating the hard part to numpy), there is not much point in fixing it in main too.
@TomNicholas TomNicholas added the bug Something isn't working label Jun 18, 2024
@TomNicholas TomNicholas mentioned this issue Jun 18, 2024
Merged
4 tasks
TomNicholas added a commit that referenced this issue Jun 18, 2024
@TomNicholas
un-xfail broadcasting test case, fixing #146
e53157e
@TomNicholas
Copy link
Member Author

Closed by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomNicholas