Handle mypy for soft imports.

zarr-developers · Nov 18, 2024 · 5de9d2c · 5de9d2c
1 parent 44bce08
commit 5de9d2c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/virtualizarr/readers/hdf/filters.py b/virtualizarr/readers/hdf/filters.py
@@ -1,5 +1,5 @@
 import dataclasses
-from typing import List, Tuple, TypedDict, Union
+from typing import TYPE_CHECKING, List, Tuple, TypedDict, Union
 
 import numcodecs.registry as registry
 import numpy as np
@@ -9,9 +9,16 @@
 
 from virtualizarr.utils import soft_import
 
-h5py = soft_import("h5py", "For reading hdf files")
-hdf5plugin = soft_import("hdf5plugin", "For reading hdf files with filters")
-imagecodecs = soft_import("imagecodecs", "For reading hdf files with filters")
+if TYPE_CHECKING:
+    import h5py  # type: ignore
+
+h5py = soft_import("h5py", "For reading hdf files", strict=False)
+hdf5plugin = soft_import(
+    "hdf5plugin", "For reading hdf files with filters", strict=False
+)
+imagecodecs = soft_import(
+    "imagecodecs", "For reading hdf files with filters", strict=False
+)
 
 
 _non_standard_filters = {

diff --git a/virtualizarr/readers/hdf/hdf.py b/virtualizarr/readers/hdf/hdf.py
@@ -1,5 +1,5 @@
 import math
-from typing import Dict, Iterable, List, Mapping, Optional, Union
+from typing import TYPE_CHECKING, Dict, Iterable, List, Mapping, Optional, Union
 
 import numpy as np
 from xarray import Dataset, Index, Variable
@@ -15,7 +15,11 @@
 from virtualizarr.utils import _FsspecFSFromFilepath, check_for_collisions, soft_import
 from virtualizarr.zarr import ZArray
 
-h5py = soft_import("h5py", "For reading hdf files")
+if TYPE_CHECKING:
+    import h5py  # type: ignore
+
+
+h5py = soft_import("h5py", "For reading hdf files", strict=False)
 
 
 class HDFVirtualBackend(VirtualBackend):