Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rough, but it works. I want to get it looked at and merged before it gets any bigger.
Primary changes
/test
. It consists of a reusable Terraform module that creates an EC2 instance and a small golang project that is separate from the golang project in the/cli
directory. Run the test withaws-vault exec your-profile-here -- make test-e2e
Secondary changes
test
andtest-close
Makefile targets tovm-init
andvm-destroy
help
: Lists all targetstest-e2e
: Run the new Terratest-based E2E teste2e-ssh
: For test development, lets you ssh into the EC2 instance that was running the E2E test for debuggingTo-Do
There's a lot to do here still. The way I want this to be looked at is as an MVP that sets up the framework.
terraform_ssh_e2e_test.go
is really big, but 95% of it will look identical for every E2E test we make, so we should extract all the boilerplate into a different file (maybe something liketest_harness.go
)e2e.sh
does the new E2E tests do/test e2e
chatops trigger (see pipeline #81)