Add a description field for zarf variable / constant declarations #844
Conversation
There was a problem hiding this comment.
Approving for now, but I don't love the description above the prompt either (feels disconnected to me)... Tagging @Madeline-UX in case she has opinions we could address in a future PR (since it would be non-breaking visual changes). Would be nice to have a guide on the use of color, prompting and displaying info even for the CLI use case.
@Racer159 Can you provide a screen capture of what you are describing here and how it looks in the CLI? |
|
Yeah I'm not sure what he's referring to, this is consistent color/placement with all other prompts / descriptions fields used in zarf cli today. It would also be very difficult to actually code the text below the input field with the current library. |
|
@Madeline-UX @jeff-mccoy I may be thinking about this weirdly, but it just feels like the description is hanging out above the prompt. Part of that could also be the way the prompt/description is worded too, but usually I am used to having a title that goes before the description and prompt to ground it more. This is how it is: This is closer to how I (subjectively) feel it should be: Not a big deal hence my approval, but something that felt weird so I mentioned it. |
|
I think you might be getting wrapped around the wording. We use this same format everywhere but the description field is not a question, that one just happened to be one in that example as a user can make it whatever they want. See component deployment prompts for how this works elsewhere. |
|
I think it is the bolding hierarchy too |
No description provided.