Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repo1 CICD dependency due to unreliable uptime #817

Merged
merged 10 commits into from
Sep 30, 2022

Conversation

jeff-mccoy
Copy link
Contributor

No description provided.

@Racer159
Copy link
Contributor

Racer159 commented Sep 30, 2022

While I agree on removing repo 1, I do think that we should replace this test case rather than completely removing it... I see it as testing two code paths:

  1. Repos that are still using go-git but use a sub-org underneath the owning org (which might fail if we screw up the git URL regex)
  2. Repos that have tags on a branch other than master (which Zarf assumes as default right now)

(if I deleted lines 89-91 we would flip the branch the tag gets pushed to)

@jeff-mccoy
Copy link
Contributor Author

I may be missing something but the test wasn't deleted, just changed the repo we were testing?

@jeff-mccoy jeff-mccoy marked this pull request as ready for review September 30, 2022 18:13
@Racer159
Copy link
Contributor

It is a test case in the test though. Some codepaths will no longer be covered without a repo like this.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-mccoy jeff-mccoy merged commit e3c20a0 into master Sep 30, 2022
@bdfinst bdfinst deleted the bye-bye-repo1-ci-dep branch January 12, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants