-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove repo1 CICD dependency due to unreliable uptime #817
Conversation
While I agree on removing repo 1, I do think that we should replace this test case rather than completely removing it... I see it as testing two code paths:
(if I deleted lines 89-91 we would flip the branch the tag gets pushed to) |
I may be missing something but the test wasn't deleted, just changed the repo we were testing? |
It is a test case in the test though. Some codepaths will no longer be covered without a repo like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine @jeff-mccoy
No description provided.