Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for git commit hashes #755

Merged
merged 9 commits into from
Sep 22, 2022
Merged

Add support for git commit hashes #755

merged 9 commits into from
Sep 22, 2022

Conversation

Racer159
Copy link
Contributor

Description

This adds support for git commit hashes, and makes git slightly more robust.

Related Issue

Fixes #747

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@Racer159 Racer159 requested review from jeff-mccoy, YrrepNoj and JasonvanBrackel and removed request for jeff-mccoy September 21, 2022 14:55
YrrepNoj
YrrepNoj reviewed Sep 21, 2022
View reviewed changes
src/internal/git/push.go Outdated Show resolved Hide resolved
YrrepNoj
YrrepNoj reviewed Sep 21, 2022
View reviewed changes
src/internal/git/checkout.go Outdated Show resolved Hide resolved
src/internal/git/fetch.go Outdated Show resolved Hide resolved
src/internal/git/fetch.go Outdated Show resolved Hide resolved
src/internal/git/pull.go Outdated Show resolved Hide resolved
src/internal/git/fetch.go Outdated Show resolved Hide resolved
@Racer159 Racer159 requested a review from YrrepNoj September 21, 2022 16:17
JasonvanBrackel
JasonvanBrackel suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@JasonvanBrackel JasonvanBrackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @YrrepNoj's earlier comment.

@Racer159 Racer159 merged commit 123368c into master Sep 22, 2022
@Racer159 Racer159 deleted the 747-support-fallback-when-git-tags-are-not-available branch September 22, 2022 15:19
jeff-mccoy added a commit that referenced this pull request Sep 23, 2022
@Racer159 @jeff-mccoy
Add support for git commit hashes (#755)
ff78441 
* Add support for git commit hashes

* Fixup example docs and comments

* Resolve Jon feedback

* Address JVB concerns

Co-authored-by: Megamind <[email protected]>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@Racer159 @jeff-mccoy
Add support for git commit hashes (#755)
4bcab65 
* Add support for git commit hashes

* Fixup example docs and comments

* Resolve Jon feedback

* Address JVB concerns

Co-authored-by: Megamind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonvanBrackel JasonvanBrackel JasonvanBrackel approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support fallback when git tags are not available
4 participants
@Racer159 @JasonvanBrackel @YrrepNoj @jeff-mccoy