Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributor & testing guides #642

Merged
merged 10 commits into from
Jul 29, 2022
Merged

Update contributor & testing guides #642

merged 10 commits into from
Jul 29, 2022

Conversation

jeff-mccoy
Copy link
Contributor

No description provided.

@jeff-mccoy
Copy link
Contributor Author

Ready for review, will include other docs changes in different PR

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) July 28, 2022 22:34
@jeff-mccoy jeff-mccoy requested review from YrrepNoj and Racer159 July 28, 2022 22:36
@jeff-mccoy
Copy link
Contributor Author

Quick note on removing the date stamp from the cobra docs. Though I do think it is somewhat useful, I think the better answer is just versioning the docs as we discussed and the way the docs generating would cause every PR to potentially have fun merge conflicts if someone else got their PR merged first:

Screen Shot 2022-07-29 at 3 31 05 PM

Screen Shot 2022-07-29 at 3 30 52 PM

@jeff-mccoy
Copy link
Contributor Author

Also note that the make docs-and-schema target uses go run main.go vs just calling the binary build as we want to ensure we have the latest/correct version of the docs/schema.

@jeff-mccoy jeff-mccoy merged commit ed14165 into master Jul 29, 2022
@jeff-mccoy jeff-mccoy deleted the docs-updates branch July 29, 2022 21:56
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants