Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle zarf shorthand removal #628

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Gracefully handle zarf shorthand removal #628

merged 1 commit into from
Jul 16, 2022

Conversation

jeff-mccoy
Copy link
Contributor

This re-adds some behavior to tell users the zarf zarf-package-thing-arch.tar.zst is no longer valid.

@jeff-mccoy
Copy link
Contributor Author

Current experience on master (not yet released)

image

New behavior

Screen Shot 2022-07-15 at 11 16 00 PM

Screen Shot 2022-07-15 at 11 15 08 PM

@jeff-mccoy jeff-mccoy added enhancement ✨ New feature or request packager labels Jul 16, 2022
Racer159
Racer159 approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests pass (which they should). This is simple and clean.

@jeff-mccoy jeff-mccoy merged commit 48b80ea into master Jul 16, 2022
@jeff-mccoy jeff-mccoy deleted the graceful-failure-on-zarf-shorthand branch July 16, 2022 04:46
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@jeff-mccoy
Gracefully handle zarf shorthand removal (#628)
1778793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-mccoy @Racer159