-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move variable definitions from components to packages #621
Conversation
We'll see how far this gets :D (will probably fail but it should kinda work) |
Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 lgtm. super excited to see this change. This one is bigger, so think we should have me & @YrrepNoj approve.
Everything lgtm, will wait for @YrrepNoj to approve since it's a bigger PR. Thanks @Racer159--outstanding work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super excited for these changes!
* WIP update schema and examples to match vision * Update schema to explicitly dissallow ###ZARF_VAR_ in default variable * Set default variables on package create * Create an initial pass at the --set flag * Make package create test more robust * Do not replace values when the default key is not present and --set is not used * Cleanup package create test * WIP start on deploy templating * Create the weird one * Mostly working now (needs more testing and stuff) * Flesh out the variable test example * Add more layers to more fully test variables * Remove image from configmap * Refactor to reduce complexity (i'm addicted pls help) * Remove xtra comments * Grammer fixes * Add validation for variables on package create * Add prompting to the deploy stage * Update CLI docs with --set option * Update Zarf schema * Remove time from Zarf schema autogen * Jeff breaking everything (though to be fair I reviewed his commit) * Fixup feedback (rando example and debug message) * Add --set to prepare find-images * Remove inspect variables load (unnecessary) * Address a TODO in a test * Catch error from survey.AskOne() * Update to new package variable/constant specification * Fix and test for some potentially bad bugs * Remove todo from SetActiveVariables * Fix import path schema * Small fixes to verbiage * put a better comment in the package variable example * Make Jeff's changes real * Move variables logic into its own file * Refactor SetActiveVariables to be better and include regex link for import path * Fixing error around taking the default * Update default to remove and add adr * Spelling mistakes and comments * Fix default on confirm check Co-authored-by: Jonathan Perry <[email protected]> Co-authored-by: Megamind <[email protected]>
Description
Move variable declarations to the package level and enable additional features such as
default
andprompt
.Related Issue
Fixes #613 --> Moves variables to the package level instead of the component level
Fixes #489 --> Adds a cli flag to override variables in a package definition
Type of change
Checklist before merging
needs-tests
label)needs-docs
label)needs-adr
label) [ 1 2 3 ]