Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update bigbang and flux resources to release 1.37.0 #609

Merged
merged 5 commits into from
Jul 12, 2022

Conversation

brandtkeller
Copy link
Contributor

Signed-off-by: brandt keller [email protected]

Description

Doing some Zarf and Big Bang testing for learning purposes. Proposing update to latest release 1.37.0 unless there is a reason otherwise. As a Big Bang contributor, I am interested in maintaining and updating this demo to reflect the intent and streamlining of Big Bang deployments with Zarf.

I'm aware of the decision to not introduce GitOps complexity for this demo. If that changes, I would be willing to pick that issue up.

Related Issue

No related issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@brandtkeller brandtkeller self-assigned this Jul 9, 2022
@jeff-mccoy
Copy link
Contributor

Thanks @brandtkeller, since we don't have an E2E for Big Bang right now, could you drop a screenshot of the deployed HelmRelease resources here for the PR and I'll approve.

@brandtkeller
Copy link
Contributor Author

Sounds good - I will work on that shortly and maybe contemplate what a E2E test for Big Bang would look like for future iterations (potential issue for others to collaborate on?).

@brandtkeller
Copy link
Contributor Author

Screen Shot 2022-07-12 at 8 34 50 AM

@brandtkeller
Copy link
Contributor Author

The above was deployed with v0.19.5

@RothAndrew
Copy link
Contributor

@jeff-mccoy can this be merged? Is there something we need to do to make the pipeline kick off?

@RothAndrew
Copy link
Contributor

@brandtkeller can you push an empty commit to trigger the pipeline? It should be going automatically but it isn't, maybe because the last commit is a merge commit? 🤷

@RothAndrew RothAndrew merged commit f60db07 into master Jul 12, 2022
@RothAndrew RothAndrew deleted the feat/BigBang_1.37_update branch July 12, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants